Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced ready for dev lead label with ready for merge team label in add-github-handle.md #7656

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Replaced ready for dev lead label with ready for merge team label in add-github-handle.md #7656

merged 1 commit into from
Oct 31, 2024

Conversation

siyunfeng
Copy link
Member

Fixes #7600

What changes did you make?

  • replaced ready for dev lead label with ready for merge team label in the file /.github/ISSUE_TEMPLATE/add-github-handle.md

Why did you make the changes (we will use this info to test)?

  • to update the label so the merge team can handle more of the issue reviews

For Reviewers

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No visual changes to the website

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b siyunfeng-replace-label-in-add-github-handle-7600 gh-pages
git pull https://github.com/siyunfeng/hackforla-website.git replace-label-in-add-github-handle-7600

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Ready for Prioritization size: 1pt Can be done in 4-6 hours labels Oct 28, 2024
@siyunfeng siyunfeng changed the title replaced ready for dev lead label with ready for merge team label in add-github-handle.md Replaced ready for dev lead label with ready for merge team label in add-github-handle.md Oct 28, 2024
@ramitaarora ramitaarora self-requested a review October 29, 2024 19:20
@ramitaarora
Copy link
Member

Availability: Weekday mornings
ETA: Oct 30 EOD

@dcotelessa
Copy link
Member

ETA: 1 hour
Availability: 4-6 W Th F

ramitaarora
ramitaarora requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@ramitaarora ramitaarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!

  • The changes look good on your branch.
  • When I follow the link for reviewers, I don't see the correct labels showing up. I believe you asked a question about this as well.
  • Since the issue template involves changing the labels specifically, I think we should make sure all the correct labels show up in the test issue on your branch.

@siyunfeng
Copy link
Member Author

Hello!

  • The changes look good on your branch.
  • When I follow the link for reviewers, I don't see the correct labels showing up. I believe you asked a question about this as well.
  • Since the issue template involves changing the labels specifically, I think we should make sure all the correct labels show up in the test issue on your branch.

Hi @ramitaarora , thank you for reviewing this PR.

I think the instruction is missing one of the actions to create new labels on my GitHub account so the labels wouldn't show. I created the corresponding labels on GitHub, which are automatically added to the templates.

Please re-review my PR and the template when you are available, thanks!

@siyunfeng siyunfeng requested a review from ramitaarora October 31, 2024 06:04
ramitaarora
ramitaarora approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@ramitaarora ramitaarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the issue and now all the labels are showing up properly. The label 'ready for dev lead' is now 'ready for merge team'.

Great work and thank you for your contribution :)

dcotelessa
dcotelessa approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@dcotelessa dcotelessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

  • change on add-github-handle shows

Thank you for your contribution!

@jphamtv jphamtv merged commit 15157bf into hackforla:gh-pages Oct 31, 2024
9 checks passed
@jphamtv
Copy link
Member

jphamtv commented Oct 31, 2024

Thanks for working on this issue @siyunfeng. Just a reminder to complete the remaining action step listed in the issue now that the PR is merged.

@siyunfeng
Copy link
Member Author

Thanks for working on this issue @siyunfeng. Just a reminder to complete the remaining action step listed in the issue now that the PR is merged.

Thanks for your reminder!

@siyunfeng siyunfeng mentioned this pull request Oct 31, 2024
Open
@siyunfeng siyunfeng deleted the replace-label-in-add-github-handle-7600 branch December 10, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramitaarora ramitaarora ramitaarora approved these changes

@dcotelessa dcotelessa dcotelessa approved these changes

Assignees
No one assigned
Labels
Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace label in add-github-handle.md
5 participants
@siyunfeng @ramitaarora @dcotelessa @jphamtv @ExperimentsInHonesty